yiguolei commented on code in PR #66825:
URL: https://github.com/apache/doris/pull/66825#discussion_r3848998221
##########
be/src/exec/operator/operator.h:
##########
@@ -652,6 +652,10 @@ class DataSinkOperatorXBase : public OperatorBase {
[[nodiscard]] virtual size_t get_reserve_mem_size(RuntimeState* state,
bool eos) {
return state->minimum_operator_memory_required_bytes();
}
+ [[nodiscard]] virtual size_t get_reserve_mem_size(RuntimeState* state,
bool eos,
Review Comment:
不要图省事单独加一个接口,要加一个block 参数,就改原来的接口就行了,可以做一个正式的改动,单独提交一个PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]