yiguolei commented on code in PR #66825:
URL: https://github.com/apache/doris/pull/66825#discussion_r3849318206
##########
be/src/exec/sink/writer/vhive_partition_writer.cpp:
##########
@@ -152,6 +170,21 @@ Status VHivePartitionWriter::close(const Status& status) {
return result_status;
}
+void VHivePartitionWriter::_register_rejected_report_cleanup() {
+ if (_rejected_report_cleanup_registered || _write_info.file_type !=
TFileType::FILE_S3 ||
+ _file_writer == nullptr) {
+ return;
+ }
+ auto* s3_writer = dynamic_cast<io::S3FileWriter*>(_file_writer.get());
+ if (s3_writer == nullptr || s3_writer->upload_id().empty()) {
+ return;
+ }
+ // The writer can be destroyed before the final RPC result; the cleanup
owns only the client
+ // and immutable upload identity needed when FE explicitly rejects
ownership.
+
_state->add_rejected_external_file_report_cleanup(s3_writer->rejected_report_cleanup());
Review Comment:
为啥这里能感知到到S3？？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
