morrySnow commented on code in PR #66633:
URL: https://github.com/apache/doris/pull/66633#discussion_r3860743982
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalTable.java:
##########
@@ -243,10 +243,6 @@ public String getEngine() {
/**
* Returns the effective meta cache engine for this table.
*/
- public String getMetaCacheEngine() {
Review Comment:
这个注释需要一起删掉
##########
fe/fe-connector/fe-connector-hive/src/main/java/org/apache/doris/connector/hive/HiveConnector.java:
##########
@@ -135,10 +138,12 @@ public HiveConnector(Map<String, String> properties,
ConnectorContext context) {
this.props = HiveCatalogProperties.of(properties);
this.properties = props.getRaw();
this.context = context;
- this.fileListingCache = new HiveFileListingCache(props);
+ this.fileListingCache = new HiveFileListingCache(metaCache, props);
Review Comment:
为什么每个connector都要显式的实现自己的cache。而不是cache对catalog透明，由core的代码统一管理，connector只负责生成被cache的对象？现在这样，如何控制cache的内存？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
