924060929 commented on code in PR #66633:
URL: https://github.com/apache/doris/pull/66633#discussion_r3861594890
##########
fe/fe-connector/fe-connector-hive/src/main/java/org/apache/doris/connector/hive/HiveConnector.java:
##########
@@ -135,10 +138,12 @@ public HiveConnector(Map<String, String> properties,
ConnectorContext context) {
this.props = HiveCatalogProperties.of(properties);
this.properties = props.getRaw();
this.context = context;
- this.fileListingCache = new HiveFileListingCache(props);
+ this.fileListingCache = new HiveFileListingCache(metaCache, props);
Review Comment:
这里 connector 显式声明的是 connector-specific 的 key、scope、loader
以及资源释放语义；缓存容器、层级注册、统一失效、并发 publication 和 lifecycle 已由
CatalogMetaCache/ScopedMetaCache 在 core runtime 统一管理。保留 definition 在 connector
侧可以避免 core 反向依赖插件类型，也能覆盖 Iceberg 这类带独立资源引用的对象。你提到的统一内存预算/治理确实还没有在本 PR
解决；这部分按计划放到 #66717 的 master 版本中接入统一 runtime，本 PR 不再扩这个 scope。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
