suxiaogang223 commented on code in PR #67163:
URL: https://github.com/apache/doris/pull/67163#discussion_r3879256545
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonMetadataOps.java:
##########
@@ -119,6 +119,13 @@ private boolean performCreateDb(String dbName, boolean
ifNotExists, Map<String,
return false;
}
+ private boolean supportsDatabaseProperties(String catalogType) {
+ return PaimonExternalCatalog.PAIMON_HMS.equals(catalogType)
+ || PaimonExternalCatalog.PAIMON_JDBC.equals(catalogType)
+ || PaimonExternalCatalog.PAIMON_REST.equals(catalogType)
Review Comment:
Fixed in `0271bad2d0`. Paimon `location` is now accepted only for HMS and
DLF, where it controls table placement; JDBC and REST reject it before
`Catalog.createDatabase`. Ordinary database properties remain supported for
JDBC and REST. Unit coverage verifies the complete capability matrix and that
no remote create is issued for the rejected location; the JDBC regression
covers the user-visible behavior.
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergMetadataOps.java:
##########
@@ -258,6 +258,12 @@ private boolean performCreateDb(String dbName, boolean
ifNotExists, Map<String,
return false;
}
+ private boolean supportsDatabaseProperties(String catalogType) {
+ return IcebergExternalCatalog.ICEBERG_HMS.equals(catalogType)
+ || IcebergExternalCatalog.ICEBERG_JDBC.equals(catalogType)
Review Comment:
Fixed in `0271bad2d0`. Database-property support is now key-specific:
Iceberg JDBC rejects `location` before `createNamespace`, while HMS and Glue
retain location support and JDBC continues to accept ordinary namespace
properties. The JDBC regression covers the rejection followed by a successful
create with `owner`, and unit tests verify that the remote namespace call is
not made for the rejected location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
