deardeng commented on code in PR #67464:
URL: https://github.com/apache/doris/pull/67464#discussion_r3923808089
##########
be/src/io/cache/peer_file_cache_reader.cpp:
##########
@@ -212,11 +260,15 @@ Status PeerFileCacheReader::fetch_blocks(const
std::vector<FileBlockSPtr>& block
}
}
std::string brpc_addr = get_host_port(realhost, port);
+ if (!peer_connection_circuit_allows(brpc_addr)) {
+ return Status::RpcError<false>("Peer connection circuit is open for
{}", brpc_addr);
+ }
Review Comment:
This is intentional. When a candidate is evicted, the next read with an
empty candidate list automatically triggers fetch_candidates_from_fe() and
falls back to remote storage. Therefore, recovery does not depend on retaining
the old candidate for a half-open probe. The address-level circuit still
prevents actual peer RPCs during the cooldown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
