deardeng commented on code in PR #67464:
URL: https://github.com/apache/doris/pull/67464#discussion_r3923811286
##########
be/src/io/cache/peer_file_cache_reader.cpp:
##########
@@ -244,8 +296,10 @@ Status PeerFileCacheReader::fetch_blocks(const
std::vector<FileBlockSPtr>& block
peer_cache_reader_read_counter << 1;
brpc_stub->fetch_peer_data(&cntl, &req, &resp, nullptr);
if (cntl.Failed()) {
+ record_peer_connection_failure(brpc_addr);
return Status::RpcError<false>(cntl.ErrorText());
}
+ record_peer_connection_success(brpc_addr);
if (resp.has_status()) {
Review Comment:
This circuit breaker intentionally covers only connection and transport
failures, such as client creation failures, timeouts, and BRPC controller
failures. A transport-successful response proves that the endpoint is
reachable, even if its application status is INTERNAL_ERROR; such
response-level errors are handled separately by the per-tablet candidate logic.
Therefore, clearing the address connection state before validating
resp.status() is intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
