github-actions[bot] commented on code in PR #67177:
URL: https://github.com/apache/doris/pull/67177#discussion_r3946286078
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/NereidsPlanner.java:
##########
@@ -267,6 +270,7 @@ private Plan planWithLock(LogicalPlan plan,
PhysicalProperties requireProperties
// pre-process logical plan out of memo, e.g. process SET_VAR hint
plan = preprocess(plan);
+ freezeLocalShufflePlannerMode();
Review Comment:
[P2] Apply retained SET_VAR hints before freezing this decision
A server-prepared statement reuses its retained `LogicalSelectHint`, but
PREPARE's temporary SET_VAR values have already been reverted by
`StmtExecutor.execute()`. On EXECUTE, this call therefore snapshots the base
session; `EliminateLogicalSelectHint` only reapplies
`SET_VAR(enable_local_shuffle_planner/enable_local_shuffle)` later in
`analyze()`. The optimizer, Exchange topology, and serialized query options
consequently ignore the statement-local mode. Please freeze or refresh the
effective decision after SET_VAR analysis (but before property derivation), or
explicitly apply retained SET_VAR before this call, and cover prepared
execution in both enable/disable directions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
