github-actions[bot] commented on code in PR #67177:
URL: https://github.com/apache/doris/pull/67177#discussion_r3956500757
##########
be/src/exec/pipeline/pipeline_fragment_context.cpp:
##########
@@ -769,13 +769,8 @@ Status
PipelineFragmentContext::_create_deferred_local_exchangers() {
sender_count, _num_instances, info.free_blocks_limit);
break;
case TLocalPartitionType::PASS_TO_ONE:
- if (_runtime_state->enable_share_hash_table_for_broadcast_join()) {
- info.shared_state->exchanger =
PassToOneExchanger::create_unique(
- sender_count, _num_instances, info.free_blocks_limit);
- } else {
- info.shared_state->exchanger =
BroadcastExchanger::create_unique(
- sender_count, _num_instances, info.free_blocks_limit);
- }
+ info.shared_state->exchanger = PassToOneExchanger::create_unique(
Review Comment:
Rechecked this thread on exact head
`fc060023b211c309cb5297d17f99f74db5e077d8` after the latest rebase, and the
compatibility issue remains applicable. The exact base
`c88e889515ecc33e90a503c274bf58e76a5758a5` already defines execution version 14
for TIMESTAMP_NS, makes 14 the FE default/max and BE max, emits PASS_TO_ONE for
a serial private broadcast build, and interprets it conditionally on BE. This
head aliases unconditional PASS_TO_ONE to that same version 14, so neither
mixed old-FE/new-BE nor new-FE/old-BE peers can distinguish the old conditional
wire meaning from the new unconditional gather. Please allocate a new execution
version (and advance the FE/BE max consistently), or introduce a distinct wire
type. Continuing the existing thread rather than creating a duplicate inline
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
