Gabriel39 commented on code in PR #67574: URL: https://github.com/apache/doris/pull/67574#discussion_r3949673335
########## regression-test/suites/external_table_p0/iceberg/test_iceberg_migrated_nested_without_name_mapping.groovy: ########## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +suite("test_iceberg_migrated_nested_without_name_mapping", "p0,external") { + String enabled = context.config.otherConfigs.get("enableIcebergTest") + if (enabled == null || !enabled.equalsIgnoreCase("true")) { + logger.info("disable iceberg test.") + return + } + + String rest_port = context.config.otherConfigs.get("iceberg_rest_uri_port") + String minio_port = context.config.otherConfigs.get("iceberg_minio_port") + String externalEnvIp = context.config.otherConfigs.get("externalEnvIp") + String catalog_name = "test_iceberg_migrated_nested_without_name_mapping" + + sql """drop catalog if exists ${catalog_name}""" + sql """ + CREATE CATALOG ${catalog_name} PROPERTIES ( + 'type'='iceberg', + 'iceberg.catalog.type'='rest', + 'uri' = 'http://${externalEnvIp}:${rest_port}', + 's3.access_key' = 'admin', + 's3.secret_key' = 'password', + 's3.endpoint' = 'http://${externalEnvIp}:${minio_port}', + 's3.region' = 'us-east-1' + ) + """ + sql """switch ${catalog_name}""" + sql """use multi_catalog""" + sql """set enable_fallback_to_original_planner=false""" Review Comment: Updated in a153237e3a: the external pipeline keeps fuzzy sessions enabled. Instead, enable_file_scanner_v2 is no longer a fuzzy variable and fuzzy initialization keeps it true, so unrelated fuzzy coverage remains active while this oracle consistently uses FileScannerV2. ########## be/src/format_v2/table/iceberg_reader.h: ########## @@ -73,6 +73,12 @@ class IcebergTableReader : public format::TableReader { if (!_data_reader.file_schema.empty() && has_field_ids) { return format::TableColumnMappingMode::BY_FIELD_ID; } + if (!_data_reader.file_schema.empty() && supports_iceberg_scan_semantics_v2(_scan_params) && Review Comment: Fixed in a153237e3a. A malformed mapping property now produces a current-schema name mapping, which is distinct from a genuinely absent property and preserves current-name reads for ID-less files. The regression covers both a required field and an optional field, including the authoritative scan-schema carrier. ########## regression-test/pipeline/external/conf/fe.conf: ########## @@ -76,7 +76,8 @@ enable_outfile_to_local = true tablet_create_timeout_second=100 remote_fragment_exec_timeout_ms=60000 fuzzy_test_type=p1 -use_fuzzy_session_variable=true +# External reader compatibility cases must consistently exercise the default FileScannerV2 path. +use_fuzzy_session_variable=false Review Comment: Fixed in a153237e3a. The pipeline-wide fuzzy gate is restored. Instead, enable_file_scanner_v2 is removed from fuzzy variables and fuzzy initialization fixes it to true, while all unrelated execution and runtime-filter fuzzing remains enabled. Dedicated compatibility cases can still select V1 explicitly after session initialization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
