github-actions[bot] commented on code in PR #67574:
URL: https://github.com/apache/doris/pull/67574#discussion_r3950036300
##########
regression-test/pipeline/external/conf/fe.conf:
##########
@@ -76,7 +76,8 @@ enable_outfile_to_local = true
tablet_create_timeout_second=100
remote_fragment_exec_timeout_ms=60000
fuzzy_test_type=p1
-use_fuzzy_session_variable=true
+# External reader compatibility cases must consistently exercise the default
FileScannerV2 path.
+use_fuzzy_session_variable=false
Review Comment:
[P1] Keep fuzzy coverage enabled outside these V2-only cases
This gate controls `initFuzzyModeVariables()` for every session in the
external pipeline. Turning it off to stabilize the new Iceberg assertions
removes the intentional FileScanner V1/V2 randomization—the initializer
explicitly keeps that toggle here for this pipeline—plus unrelated
execution/runtime-filter fuzzing across the suite. Keep this pipeline-wide gate
enabled and save/set/restore `enable_file_scanner_v2=true` only around the
V2-specific assertions, following the existing Iceberg suite pattern.
##########
be/src/format_v2/table/iceberg_reader.h:
##########
@@ -73,6 +73,12 @@ class IcebergTableReader : public format::TableReader {
if (!_data_reader.file_schema.empty() && has_field_ids) {
return format::TableColumnMappingMode::BY_FIELD_ID;
}
+ if (!_data_reader.file_schema.empty() &&
supports_iceberg_scan_semantics_v2(_scan_params) &&
Review Comment:
[P1] Preserve malformed name-mapping fallback state
`IcebergSchemaUtils.extractNameMapping()` intentionally catches malformed
`schema.name-mapping.default` and returns `Optional.empty()`, while
`populateScanLevelParams()` still sends semantics V2. This branch now treats
that carrier as a genuinely absent mapping and chooses `BY_FIELD_ID` for an
ID-less file. On a current FE/BE pair, previously name-readable optional fields
can silently become NULL/defaults and required fields fail, contradicting
`extractNameMappingFailsSoftOnMalformedProperty`. Preserve a distinct
parse-failed/legacy-fallback state (or reject the malformed property clearly),
and cover ID-less optional and required fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
