github-actions[bot] commented on code in PR #67811:
URL: https://github.com/apache/doris/pull/67811#discussion_r4002298304
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -457,7 +455,6 @@ public String toString() {
public static final String REWRITE_OR_TO_IN_PREDICATE_THRESHOLD =
"rewrite_or_to_in_predicate_threshold";
public static final String NEREIDS_CBO_PENALTY_FACTOR =
"nereids_cbo_penalty_factor";
- public static final String ENABLE_NEREIDS_TRACE = "enable_nereids_trace";
public static final String ENABLE_EXPR_TRACE = "enable_expr_trace";
Review Comment:
Please preserve both retired names in
`VariableMgr.REMOVED_SESSION_VAR_NAMES` before deleting these registrations.
Once these `@VarAttr` fields are gone, `getVarContext()` returns null, and
direct or forwarded `SET`, `SET_VAR`, and `SELECT @@` only take the
retired-variable compatibility path for names in that set; otherwise existing
client initialization and diagnostic traffic fails with
`ERR_UNKNOWN_SYSTEM_VARIABLE` on an upgraded FE. This is why the set already
contains recent removals such as `plan_nereids_dump` and
`enable_paimon_cpp_reader`. Please add `enable_nereids_trace` and
`nereids_trace_event_mode` in lowercase, ideally with removed-variable SET/read
coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
