github-actions[bot] commented on code in PR #67811: URL: https://github.com/apache/doris/pull/67811#discussion_r4004690267
########## fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/MinidumpAction.java: ########## @@ -1,69 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor license agreements. See the NOTICE file -// distributed with this work for additional information -// regarding copyright ownership. The ASF licenses this file -// to you under the Apache License, Version 2.0 (the -// "License"); you may not use this file except in compliance -// with the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, -// software distributed under the License is distributed on an -// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -// KIND, either express or implied. See the License for the -// specific language governing permissions and limitations -// under the License. - -package org.apache.doris.httpv2.rest; - -import org.apache.doris.httpv2.controller.BaseController.ActionAuthorizationInfo; -import org.apache.doris.httpv2.entity.ResponseEntityBuilder; -import org.apache.doris.nereids.minidump.MinidumpUtils; - -import com.google.common.base.Strings; -import jakarta.servlet.http.HttpServletRequest; -import jakarta.servlet.http.HttpServletResponse; -import org.apache.logging.log4j.LogManager; -import org.apache.logging.log4j.Logger; -import org.springframework.http.HttpHeaders; -import org.springframework.http.MediaType; -import org.springframework.http.ResponseEntity; -import org.springframework.web.bind.annotation.RequestMapping; -import org.springframework.web.bind.annotation.RequestMethod; -import org.springframework.web.bind.annotation.RestController; - -// This class is a RESTFUL interface to get query minidump. -// It will be used in query monitor to collect minidumps. -// Usage: -// wget http://fe_host:fe_http_port/api/minidump?query_id=123456 -@RestController -public class MinidumpAction extends RestBaseController { Review Comment: [P2] Clean deleted FE classes before incremental packaging `./build.sh --fe` defaults to a non-clean Maven `package`, so on a cache-miss build after checking out this head over a base-built tree, javac leaves this deleted controller and `MinidumpUtils` under `fe/fe-core/target/classes`, and the jar plugin packages them again. Spring then still registers `/api/minidump`; invoking it initializes the stale utility against the new `Config` and throws `NoSuchFieldError` for `spilled_minidump_storage_path`. Please make the standard FE packaging path remove the deleted class outputs or otherwise force a clean for this transition, and verify the resulting jar no longer contains them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
