Gabriel39 commented on code in PR #67784:
URL: https://github.com/apache/doris/pull/67784#discussion_r4002363362


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/materialize/MaterializeProbeVisitor.java:
##########
@@ -209,6 +219,25 @@ public Optional<MaterializeSource> 
visitPhysicalTVFRelation(
         return Optional.empty();

Review Comment:
   Fixed in 01357d9f72. The external materialization gate now recursively 
rejects VARIANT via VariantType.containsVariant as well as timestamp leaves 
before lazy pruning can hide them from regular scan validation. Both 
Iceberg/catalog scans and Parquet/ORC TVFs retain these outputs in phase one; 
ordinary passive columns remain eligible, and internal OLAP and Lance retain 
their independent paths. Added real TopN-plan tests for top-level and nested 
VARIANT across Iceberg and S3/HDFS/LOCAL TVFs, plus an Iceberg integration 
regression comparing lazy materialization on/off. Both reproductions failed 
before the fix and pass afterward; all 14 related FE tests and FE Checkstyle 
pass. The integration regression is syntax-checked; its full execution is 
pending CI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to