github-actions[bot] commented on code in PR #67784:
URL: https://github.com/apache/doris/pull/67784#discussion_r4002319993
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/materialize/MaterializeProbeVisitor.java:
##########
@@ -209,6 +219,25 @@ public Optional<MaterializeSource>
visitPhysicalTVFRelation(
return Optional.empty();
Review Comment:
[P1] Keep external VARIANT leaves in phase one too
The new recursive gate immediately below only rejects timestamp leaves. With
the default TopN lazy-materialization threshold, a query such as `SELECT id, v
FROM <Iceberg table> ORDER BY id LIMIT n` can still make a passive top-level or
nested VARIANT lazy; the same applies to supported Parquet/ORC TVFs. Lazy-slot
pruning removes that column from phase one, so the ordinary recursive VARIANT
gate never sees it. Phase two then directly constructs legacy `FileScanner` in
`RowIdStorageReader::read_external_row_from_file_mapping()`, even though the
file-scan operator explicitly rejects external VARIANT on that scanner. The V2
phase can therefore succeed and fetching the selected rows fails. Please reject
`VariantType.containsVariant(type)` here as well (or route row-ID fetch through
V2), and cover a TopN with passive external VARIANT output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
