github-actions[bot] commented on code in PR #67154:
URL: https://github.com/apache/doris/pull/67154#discussion_r4014717383
##########
regression-test/suites/query_p0/variables_persist/test_mtmv.groovy:
##########
@@ -104,10 +104,11 @@ suite("test_mtmv") {
"""
sql "set enable_decimal256=false;"
qt_pre_mv_rewrite "select /*+use_mv(mv_pre_mv_rewrite)*/ * from
v_distinct_agg_rewrite order by 1,2;"
- explain {
- sql "select /*+use_mv(mv_pre_mv_rewrite)*/ * from
v_distinct_agg_rewrite;"
- contains "mv_pre_mv_rewrite chose"
- }
+ // uncomment this after fixing use_mv hint bug
Review Comment:
[P1] Keep the MV-choice assertion enabled
This removes the only check that the forced `use_mv(mv_pre_mv_rewrite)`
query actually selects `mv_pre_mv_rewrite`. The preceding `qt_pre_mv_rewrite`
validates only the result rows, which are also correct when the hint is ignored
and the base view/table plan runs, so the suite now passes while the comment
says the hint bug remains. Since this PR does not fix or intentionally change
MV-hint behavior, please restore the `explain ... contains "mv_pre_mv_rewrite
chose"` assertion and fix the regression it exposes (or move an independently
tracked pre-existing workaround out of this PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
