yiguolei commented on code in PR #67784:
URL: https://github.com/apache/doris/pull/67784#discussion_r4023583139
##########
be/src/format/arrow/arrow_block_convertor.h:
##########
@@ -43,32 +43,59 @@ class Schema;
namespace doris {
+// ORC and Arrow Iceberg writers share this parser so textual and binary UUID
inputs always use
+// the same canonical 16-byte representation.
Status parse_iceberg_uuid_to_bytes(StringRef uuid, std::array<uint8_t, 16>*
bytes);
+class ArrowWriteConverter {
Review Comment:
FromBlockToRecordBatchConverter 和 ArrowWriteConverter 有点乱。 我感觉我们需要的是这么个东西
ArrowBlockConvertor {
Status convert_from_arrow(Const arrowblock, Block* doris_block);
Status convert_to_arrow(Const doris_block, arrow_block* block);
}
但是这个类有好几种实现，比如
ArrowFlightArrowBlockConvertor
IcebergArrowBlockConvertor
等等
比如IcebergArrowBlockConvertor可能是这个样子
public class IcebergArrowBlockConvertor : public ArrowBlockConvertor {
IcebergArrowBlockConvertor(string iceberg schema, ) // 可以再构造函数中把iceberg
的schema 传递进去，然后我们可以去翻译iceberg的schema 到arrow 的schema
}
比如parquet writer里面，我们就可以在IcebergParquetTransformer
里调用IcebergArrowBlockConvertor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
