mrhhsg commented on code in PR #68125:
URL: https://github.com/apache/doris/pull/68125#discussion_r4045999360


##########
be/src/exec/rowid_fetcher.cpp:
##########
@@ -1049,6 +1067,8 @@ Status RowIdStorageReader::read_doris_format_row(
                     iterator_item.storage_read_options, 
iterator_item.iterator));
         }
     }
+    replace_rowid_read_time_hidden_columns(full_read_schema, slots, *rowset, 
row_ids.size(),
+                                           result_block);

Review Comment:
   Addressed in e007d1502399206c8d43faafafa072fbfd31eed9. The regression now 
forces PhysicalLazyMaterialize and executes the 
PMultiGetRequestV2/RowIdStorageReader path. Two inserts create singleton 
rowsets at versions 2 and 3, while sort keys interleave their rows so the 
asserted VERSION output is exactly 2,3,2,3 after batch scattering. The same 
oracle covers both direct-column and full row-store fetches. I generated the 
expected output and reran the focused suite successfully.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to