github-actions[bot] commented on code in PR #68125:
URL: https://github.com/apache/doris/pull/68125#discussion_r4045595684
##########
be/src/exec/rowid_fetcher.cpp:
##########
@@ -1049,6 +1067,8 @@ Status RowIdStorageReader::read_doris_format_row(
iterator_item.storage_read_options,
iterator_item.iterator));
}
}
+ replace_rowid_read_time_hidden_columns(full_read_schema, slots, *rowset,
row_ids.size(),
+ result_block);
Review Comment:
Add an execution test for this row-ID materialization path. The new
regression exercises PointQueryExecutor/MINMAX, and the segment test never
reaches `PMultiGetRequestV2` or `RowIdStorageReader`, so nothing currently
verifies that hidden values are corrected with each deduplicated batch's own
rowset metadata before interleaved rows are scattered back. Please force lazy
TopN, select `__DORIS_VERSION_COL__`, and assert exact per-row versions from at
least two singleton rowsets; cover the row-store and direct-column variants
where practical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
