github-actions[bot] commented on code in PR #68281:
URL: https://github.com/apache/doris/pull/68281#discussion_r4064259092
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -4148,10 +4154,45 @@ public void setMaxExecutionTimeMS(String
maxExecutionTimeMS) {
}
public void setPipelineTaskNum(String value) throws Exception {
- int val = checkFieldValue(PARALLEL_PIPELINE_TASK_NUM, 0, value);
+ int val = checkFieldValue(PARALLEL_PIPELINE_TASK_NUM, 0, 256, value);
this.parallelPipelineTaskNum = val;
}
+ public void checkColocateMaxParallelNum(String value) throws Exception {
+ checkFieldValue(COLOCATE_MAX_PARALLEL_NUM, 1, 256, value);
+ }
+
+ public void checkMaxScannersConcurrency(String value) throws Exception {
+ // Non-positive scanner concurrency values select the BE defaults.
+ checkFieldValue(MAX_SCANNERS_CONCURRENCY, Integer.MIN_VALUE, 256,
value);
+ }
+
+ public void checkMaxFileScannersConcurrency(String value) throws Exception
{
+ checkFieldValue(MAX_FILE_SCANNERS_CONCURRENCY, Integer.MIN_VALUE, 256,
value);
+ }
+
+ public void checkMinScannersConcurrency(String value) throws Exception {
+ checkFieldValue(MIN_SCANNERS_CONCURRENCY, Integer.MIN_VALUE, 256,
value);
+ }
+
+ public void checkMinFileScannersConcurrency(String value) throws Exception
{
+ checkFieldValue(MIN_FILE_SCANNERS_CONCURRENCY, Integer.MIN_VALUE, 256,
value);
+ }
+
+ public void checkParallelScanMaxScannersCount(String value) throws
Exception {
+ // Non-positive values select the number of CPU cores on the BE.
+ checkFieldValue(PARALLEL_SCAN_MAX_SCANNERS_COUNT, Integer.MIN_VALUE,
256, value);
+ }
+
+ public void checkSendBatchParallelism(String value) throws Exception {
+ // The tablet writer uses one sender for values less than or equal to
one.
+ checkFieldValue(SEND_BATCH_PARALLELISM, Integer.MIN_VALUE, 256, value);
+ }
Review Comment:
[P1] Bound the HTTP send-batch override
Separate from the existing broker/routine LOAD-property thread, HTTP Stream
Load parses `send_batch_parallelism` only as an `i32`, copies it unchanged
through `NereidsStreamLoadTask`, and gives it to V1 `VTabletWriter` as the
token's per-job concurrency ceiling. Pool-wide worker/queue limits bound
aggregate execution, but there is still no 256 per-job cap, so a larger
configured pool can run more than 256 sends for one load. Validate the same
ceiling at the request/planning boundary, retain a BE-side check for
mixed-version requests, and cover this header path directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
