github-actions[bot] commented on code in PR #68281:
URL: https://github.com/apache/doris/pull/68281#discussion_r4070143582
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -4148,10 +4154,45 @@ public void setMaxExecutionTimeMS(String
maxExecutionTimeMS) {
}
public void setPipelineTaskNum(String value) throws Exception {
- int val = checkFieldValue(PARALLEL_PIPELINE_TASK_NUM, 0, value);
+ int val = checkFieldValue(PARALLEL_PIPELINE_TASK_NUM, 0, 256, value);
this.parallelPipelineTaskNum = val;
}
+ public void checkColocateMaxParallelNum(String value) throws Exception {
+ checkFieldValue(COLOCATE_MAX_PARALLEL_NUM, 1, 256, value);
+ }
+
+ public void checkMaxScannersConcurrency(String value) throws Exception {
+ // Non-positive scanner concurrency values select the BE defaults.
+ checkFieldValue(MAX_SCANNERS_CONCURRENCY, Integer.MIN_VALUE, 256,
value);
+ }
+
+ public void checkMaxFileScannersConcurrency(String value) throws Exception
{
+ checkFieldValue(MAX_FILE_SCANNERS_CONCURRENCY, Integer.MIN_VALUE, 256,
value);
+ }
+
+ public void checkMinScannersConcurrency(String value) throws Exception {
+ checkFieldValue(MIN_SCANNERS_CONCURRENCY, Integer.MIN_VALUE, 256,
value);
+ }
Review Comment:
[P1] Cap the effective per-user parallelism too
The new setter rejects 257, but `getParallelExecInstanceNum` returns the
persisted `parallel_fragment_exec_instance_num` user property first. `SET
PROPERTY` can store 2000 (the existing `UserPropertyTest` does exactly that),
so later planning and Thrift serialization still carry 2000 as the effective
requested parallelism and can create more than 256 instances when the plan/data
shape permits. This is distinct from the existing SessionVariable map/image
threads because it comes from the separate user-property store and has getter
precedence. Reject new over-cap property writes, and clamp or migrate
historical image/journal values when resolving them so upgrades cannot bypass
the bound.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
