mrhhsg commented on code in PR #68426:
URL: https://github.com/apache/doris/pull/68426#discussion_r4081582830
##########
be/src/exprs/aggregate/aggregate_function_map_v2.cpp:
##########
@@ -56,6 +56,8 @@ AggregateFunctionPtr
create_aggregate_function_map_agg_v2(const std::string& nam
case PrimitiveType::TYPE_TIMESTAMP_NS:
case PrimitiveType::TYPE_TIMEV2:
case PrimitiveType::TYPE_TIMESTAMPTZ:
+ case PrimitiveType::TYPE_IPV4:
+ case PrimitiveType::TYPE_IPV6:
Review Comment:
Fixed in 7f7e50c8a8b. The key state buffer is now resized to the actual
`written_bytes`. I added an ASAN BE unit test that round-trips `map_agg_v2`
states through `AggregateStateUnion` and `AggregateStateMerge` at 65 IPv4 / 17
IPv6 keys, plus end-to-end state-merge regression coverage. The focused unit
test, generated-output regression rerun, ASAN BE+FE build, changed-line
clang-tidy, formatting, and build-hygiene checks all pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
