mrhhsg commented on code in PR #68426:
URL: https://github.com/apache/doris/pull/68426#discussion_r4084585531
##########
be/src/exprs/aggregate/aggregate_function_map_v2.h:
##########
@@ -129,7 +129,7 @@ struct AggregateFunctionMapAggDataV2 {
int64_t written_bytes = buf_ptr - serialized_buffer.data();
DCHECK_LE(written_bytes, serialized_bytes);
- serialized_buffer.resize(serialized_bytes);
+ serialized_buffer.resize(written_bytes);
Review Comment:
Fixed in abd8b597119383b06a2c7ba4487bb6276e3981c8. Both key and value frames
are now read into `PaddedPODArray`, so the StreamVByte decoder has a private
readable suffix while the saved logical end is checked with `DORIS_CHECK_EQ` in
the new format.
The exact frame is gated by BE execution version 16. New BEs select an
alternative legacy implementation for versions through 15; that writer
preserves the old upper-bound key frame and its reader validates the complete
legacy envelope. IPv4/IPv6 dispatch is enabled only for version 16, since old
BEs cannot execute those key types. The focused UT now verifies exact-vs-legacy
frame sizes and round-trips both formats; the IP regression, ASAN BE UT, BE/FE
build, format, build-hygiene, and changed-line clang-tidy checks pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
