eldenmoon commented on code in PR #68461:
URL: https://github.com/apache/doris/pull/68461#discussion_r4089127283
##########
be/src/exprs/function/cast/cast_to_variant.h:
##########
@@ -76,6 +76,21 @@ inline Status cast_from_variant_impl(FunctionContext*
context, Block& block,
data_type_to->get_primitive_type() != TYPE_JSONB);
if (is_root_valuable) {
+ if (is_string_type(data_type_to->get_primitive_type()) &&
Review Comment:
This code is too tricky. We can accept this boolean behavior in version 4.1,
as it has already been fixed on master (which will be released in Doris 5.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]