akashchamp commented on code in PR #68461:
URL: https://github.com/apache/doris/pull/68461#discussion_r4104110986


##########
be/src/exprs/function/cast/cast_to_variant.h:
##########
@@ -76,6 +76,21 @@ inline Status cast_from_variant_impl(FunctionContext* 
context, Block& block,
                              data_type_to->get_primitive_type() != TYPE_JSONB);
 
     if (is_root_valuable) {
+        if (is_string_type(data_type_to->get_primitive_type()) &&

Review Comment:
   Already resolved prior to this session (eldenmoon accepted the boolean 
special-case as intentional for the 4.1 backport; akashchamp confirmed no code 
change needed). No further action required on this thread.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to