github-actions[bot] commented on code in PR #69091:
URL: https://github.com/apache/doris/pull/69091#discussion_r4278753199
##########
thirdparty/build-thirdparty.sh:
##########
@@ -2476,7 +2476,10 @@ build_lance_c() {
echo "failed to get cargo version for lance-c. Install Rust
${required_rust_version} or set LANCE_C_CARGO/RUSTUP_TOOLCHAIN."
exit 1
fi
- # Rust 1.94.0 is the minimum supported version. Allow newer toolchains when
+ local rustc_version
+ rustc_version="$(env "${cargo_env[@]}" "${RUSTC:-rustc}" --version)"
Review Comment:
[P2] Keep compiler diagnostics compatible with Cargo overrides
With `CARGO=/opt/rust/bin/cargo` (or either package-specific override) and
`CARGO_BUILD_RUSTC=/opt/rust/bin/rustc`, `RUSTC` can be unset and `rustc`
absent from `PATH`. [Cargo supports that compiler
configuration](https://doc.rust-lang.org/cargo/reference/config.html#buildrustc),
but this new assignment invokes bare `rustc`; `env` exits 127 and the script's
`set -e` stops the build before the Cargo build runs. Both this function and
`build_paimon_rust` now reject a setup that previously worked, even with the
formerly required Rust 1.94 toolchain. Query Cargo's effective compiler or make
the informational diagnostic tolerate its supported compiler overrides,
including `build.rustc` in Cargo configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
