github-actions[bot] commented on code in PR #69091:
URL: https://github.com/apache/doris/pull/69091#discussion_r4278930641
##########
thirdparty/build-thirdparty.sh:
##########
@@ -2579,7 +2580,8 @@ build_paimon_rust() {
Review Comment:
[P1] Keep Paimon at Rust 1.94 on AArch64. The pinned paimon-rust v0.4.0-rc1
raised its MSRV to 1.94 because its non-optional `paimon-vindex-core`
dependency uses `std::arch::aarch64` NEON FP16 intrinsics stabilized in Rust
1.94. `bindings/c` pulls that crate through `paimon`, and this script runs
`paimon_rust` in the macOS-arm64 full third-party job. With rustup (the normal
runner setup), the preceding block selects `RUSTUP_TOOLCHAIN=1.91.0`;
`--ignore-rust-version` only suppresses Cargo's metadata check, so compilation
still fails on that target. Keep 1.94 for Paimon/AArch64 or gate the lower
toolchain by target instead of bypassing this MSRV globally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
