yiguolei commented on code in PR #69066:
URL: https://github.com/apache/doris/pull/69066#discussion_r4279903334


##########
be/src/runtime/descriptors.cpp:
##########
@@ -191,7 +190,7 @@ void SlotDescriptor::to_protobuf(PSlotDescriptor* pslot) 
const {
 }
 
 DataTypePtr SlotDescriptor::get_data_type_ptr() const {

Review Comment:
   if this function call type() then why not delete this function and using 
type() instead in all dependencies?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to