924060929 commented on code in PR #69300:
URL: https://github.com/apache/doris/pull/69300#discussion_r4321592016
##########
be/src/format_v2/table_reader.h:
##########
@@ -148,6 +152,7 @@ struct TableReadOptions {
std::shared_ptr<io::IOContext> io_ctx;
RuntimeState* runtime_state;
RuntimeProfile* scanner_profile;
+ parquet::ParquetProfileCache* parquet_profile_cache = nullptr;
Review Comment:
Fixed in eb06287e7d42567a50617746ce047c963456b5fe. The scan-owned Parquet
cache now owns separate caches for nested RuntimeProfiles. The position-deletes
system-table reader retains the cache for IcebergPositionDeleteFileReader
across splits; separate scanner instances resolve the same child cache.
Standalone readers retain an independently owned child cache. The outer
counters are never forwarded. Added actual nested factory coverage across
repeated splits/scanners and concurrent child-cache identity/isolation
coverage. ASAN build, 446 scoped UTs, clang-format 16, header hygiene and
clang-tidy passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
