morningman commented on PR #69536: URL: https://github.com/apache/doris/pull/69536#issuecomment-6383396241
Addressed the second review round in `cbf21fb0585`. Per finding: - 4363903193 (P1, v3 DATE→TIMESTAMP narrowed): fixed. The widening now starts from the selected definition and follows only recognized promotions, the SDK rules plus DATE→unzoned TIMESTAMP/TIMESTAMP_NS, so it can no longer narrow a key. - 4363903205 (P2, schema-only optionality lost): fixed. A dropped key is optional when any retained schema has it optional; a key required in every retained schema stays required. Four new tests in `IcebergScanPlanProviderTest`; all 1698 tests of fe-connector-iceberg pass. The PR description is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
