morningman commented on PR #69536: URL: https://github.com/apache/doris/pull/69536#issuecomment-6385130254
Addressed the third review round in `36bac832997`. Per finding: - 4366960335 (P2, DATE defaults on a promoted carrier): fixed. A DATE default now moves to midnight in the promoted TIMESTAMP/TIMESTAMP_NS type before the field is rebuilt. - 4366960337 (P2, a later nanosecond promotion for a pinned DATE read): kept as is and explained in the thread. The FE cannot order retained schemas against the scan target, so dropping the widening would bring back silent wrong rows for schema-only promotions. The remaining error fails closed and is left to a BE-side change. Two new tests in `IcebergScanPlanProviderTest`; all 1700 tests of fe-connector-iceberg pass. The PR description is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
