morningman commented on PR #69536: URL: https://github.com/apache/doris/pull/69536#issuecomment-6391105431
Addressed the fourth review round in `9affde5af66`. Per finding: - 4367404920 (P1, a dropped key recovered as `unknown`): fixed. `unknown` now promotes to any primitive type when the carrier takes a key's retained promotions, so the key keeps the type its tombstones were written in. - 4366960335 (residual, copied DATE write default): fixed. A rebuilt carrier field drops its write default, which no reader uses, instead of converting it. Two new tests in `IcebergScanPlanProviderTest`; all 1702 tests of fe-connector-iceberg pass. The PR description is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
