morningman commented on PR #69536: URL: https://github.com/apache/doris/pull/69536#issuecomment-6393819063
Addressed the fifth review round in `b4bb074bfed`. Per finding: - 4369032165 (P1, TIMESTAMP and TIMESTAMP_NS competing after a schema rollback): fixed. A dropped key's carrier type no longer depends on the order of the schema list: it is the retained promotion that every other one promotes to, and planning fails with an explicit error when a rollback left two unrelated promotions (DATE to both TIMESTAMP and TIMESTAMP_NS, or `unknown` to two types). This also covers the `unknown` variant of the same history. Four new tests in `IcebergScanPlanProviderTest`; all 1706 tests of fe-connector-iceberg pass. The PR description is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
