OIiveirra commented on code in PR #69591:
URL: https://github.com/apache/doris/pull/69591#discussion_r4374489775
##########
regression-test/suites/datatype_p0/uuid/test_uuid_csv_schema.groovy:
##########
@@ -19,27 +19,17 @@
suite("test_uuid_csv_schema", "p0,external") {
sql "SET enable_sql_cache = false"
sql "SET enable_query_cache = false"
- String localPath = context.config.otherConfigs.get('uuidLocalExportPath')
String token = UUID.randomUUID().toString()
def sources = [:]
for (String kind : ['values', 'invalid']) {
File fixture = new File(context.dataPath,
"test_data/uuid_external_${kind}.csv")
- if (localPath != null) {
- File target = new File("${localPath}_${token}_${kind}.csv")
- java.nio.file.Files.copy(fixture.toPath(), target.toPath())
- String path =
"${context.config.otherConfigs.get('uuidLocalTvfPath')}_${token}_${kind}.csv"
- sources[kind] = """LOCAL('file_path'='${path}',
- 'backend_id'='${(sql 'SHOW
BACKENDS')[0][0]}','format'='csv',
- 'column_separator'=',','csv_schema'='id:int;u:uuid')"""
- } else {
- String bucket = context.config.otherConfigs.get('s3BucketName')
- String key = "uuid_csv_schema/${token}/${kind}.csv"
- getS3Client().putObject(bucket, key, fixture)
- sources[kind] = """S3('uri'='s3://${bucket}/${key}','format'='csv',
- 'column_separator'=',','csv_schema'='id:int;u:uuid',
-
's3.endpoint'='${getS3Endpoint()}','s3.region'='${getS3Region()}',
-
's3.access_key'='${getS3AK()}','s3.secret_key'='${getS3SK()}')"""
- }
+ String bucket = context.config.otherConfigs.get('s3BucketName')
+ String key = "uuid_csv_schema/${token}/${kind}.csv"
+ getS3Client().putObject(bucket, key, fixture)
Review Comment:
Fixed in ef4eca40d333bd9320f03bdee876fdf3a208563f, with the same fix in
#69592 (b3f5fb8da8d7e14470eee0d3be00de80c75cdbc0). The three UUID fixture
suites select the already-declared Azure Blob SDK for Azure uploads and pass
the matching provider/endpoint to the TVF. The default Azure endpoint
placeholder is resolved; explicit endpoints are preserved. Existing S3 uploads,
fixture lifetimes and every schema/value/profile assertion remain unchanged.
Only these three Groovy files changed per branch; no production, helper,
dependency or output-reference changes. Six scripts compiled and twelve
loopback SDK scenarios verified the exact setup/upload blocks, original fixture
bytes and generated TVF parameters. These checks did not execute SQL or
validate a live Azure/Doris cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
