924060929 commented on code in PR #69632:
URL: https://github.com/apache/doris/pull/69632#discussion_r4385384451
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonExternalTable.java:
##########
@@ -403,12 +407,17 @@ public boolean isPartitionColumnAllowNull() {
@Override
public MvccSnapshot loadSnapshot(Optional<TableSnapshot> tableSnapshot,
Optional<TableScanParams> scanParams) {
- return new
PaimonMvccSnapshot(getPaimonSnapshotCacheValue(tableSnapshot, scanParams));
+ return withMissingTableRepair(() -> {
Review Comment:
Fixed in 1e6cd5af7460. The common getOrFetchSnapshotCacheValue() live
fallback now uses retained lookup repair, covering direct partition snapshot
readers. The newest-version read is guarded too. The real SHOW PARTITIONS
helper test succeeds in warm-table partition validation and fails only in the
later snapshot fallback; timeout, version and pinned-local-snapshot cases are
covered. Retained snapshots do not observe or reload a live catalog; the
existing Paimon main/branch identifier classification remains unchanged.
Validation: 254 selected FE cases passed on final source; FE build and
Checkstyle passed. New SDK failures are mocked; no live-service/full SQL
analyzer integration claim.
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java:
##########
@@ -710,12 +733,20 @@ public Partition getPartition(List<String>
partitionValues) {
return client.getPartition(getRemoteDbName(), remoteName,
partitionValues);
}
+ public List<String> listPartitionNames() {
+ return withMissingTableRepair(() -> ((HMSExternalCatalog)
catalog).getClient()
Review Comment:
Fixed in 1e6cd5af7460. The whole getHivePartitionValues() read, including
the existing inconsistency retry, is now guarded at the resolved HMS table.
Tests enter initSelectedPartitions() with warm partition columns and fail only
in the live partition-values cache read; confirmed absence repairs, timeout
does not, and a delayed failure preserves a same-name replacement.
Retry-then-absence is covered. Individual partition absence still does not
authorize base retirement.
Validation: 254 selected FE cases passed on final source; FE build and
Checkstyle passed. New SDK failures are mocked; no live-service/full SQL
analyzer integration claim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
