Gabriel39 commented on code in PR #69672:
URL: https://github.com/apache/doris/pull/69672#discussion_r4386196140
##########
fe/fe-connector/fe-connector-es/src/main/java/org/apache/doris/connector/es/EsQueryDslBuilder.java:
##########
@@ -143,6 +158,11 @@ public static EsQueryDslResult
buildQueryDslWithResult(ConnectorExpression filte
return new EsQueryDslResult(queryDsl, notPushedIndices);
}
+ // Dropping a source-value predicate after translating a
transformed/missing index value
+ // cannot be repaired by a residual: matching source documents may
already be absent.
+ if (referencesUnsafeSourceField(filter, sourceValueUnsafeFields)) {
Review Comment:
Fixed in bdc4c2465c. Equality and positive IN on keyword values within the
minimum ignore_above bound of every backing mapping remain exact and can
participate in remote OR/NOT expressions, provided no normalizer/null
substitution/other source transformation applies. Text keyword subfields also
require keyword sniff. Genuinely inexact Boolean combinations containing
remote-only esquery now fail during FE planning with a clear diagnostic instead
of becoming an unevaluable BE residual; separate top-level AND conjuncts still
support remote native queries plus local source filters. Added FE boundary
tests and live ES8 SQL coverage for successful native OR/NOT, source-local AND,
and expected planning failures. The pre-update SQL suite reproduced the
fake-function error. Final verification: 139 ES FE tests passed, one optional
external class skipped; 344 snapshots, 256 independent comparisons and 16
expected planning-error checks passed across eight configurations. The original
288 snap
shots remain unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
