Gabriel39 commented on code in PR #69672:
URL: https://github.com/apache/doris/pull/69672#discussion_r4386564816
##########
fe/fe-connector/fe-connector-es/src/main/java/org/apache/doris/connector/es/EsQueryDslBuilder.java:
##########
@@ -143,6 +158,11 @@ public static EsQueryDslResult
buildQueryDslWithResult(ConnectorExpression filte
return new EsQueryDslResult(queryDsl, notPushedIndices);
}
+ // Dropping a source-value predicate after translating a
transformed/missing index value
+ // cannot be repaired by a residual: matching source documents may
already be absent.
+ if (referencesUnsafeSourceField(filter, sourceValueUnsafeFields)) {
Review Comment:
Correction to my earlier reply: the bounded-literal claim was incorrect. ES
mappings cannot establish scalar source values, so a short equality can match
one element of an array that Doris reads as a JSON STRING. Commit cff8803bf3
removes that exemption rather than refining the length heuristic. Affected SQL
predicates remain local; an indivisible Boolean expression containing
remote-only esquery is rejected when it would need local evaluation. Unaffected
selected paths and separate top-level AND conjuncts remain supported. The
updated live suite checks ordinary STRING predicates against internal tables
and native array matching against ES itself. Final validation: 144 FE tests
passed, one optional external class skipped, Checkstyle passed, and 488 stored
results / 400 independent comparisons / 48 expected planning errors passed
across eight configurations, including a separate non-generation rerun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
