This is an automated email from the ASF dual-hosted git repository.
HappenLee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 015dbb6b0b0 [refactor](be) Remove unused column APIs (#69758)
015dbb6b0b0 is described below
commit 015dbb6b0b0d02b5352b62a72c278fde975d0613
Author: HappenLee <[email protected]>
AuthorDate: Thu Oct 29 10:47:13 2026 +0800
[refactor](be) Remove unused column APIs (#69758)
### What problem does this PR solve?
Issue Number: None
Problem Summary: `IColumnDummy::addSize()` and
`ColumnDictI32::Dictionary::avg_str_len()` have no callers. Remove both
helpers, along with the unused `_total_str_len` counter and its
per-insert update.
### Release note
None
### Check List (For Author)
- Test
- [ ] Regression test
- [ ] Unit Test
- [x] Manual test
- Tracked-source reference audit: no remaining references to the removed
APIs or counter.
- Repository clang-format 16, check-format, header hygiene, and `git
diff --check` passed.
- Compilation and runtime tests were not run: this only removes
unreferenced inline APIs and private write-only bookkeeping.
- Behavior changed:
- [x] No.
- [ ] Yes.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
---
be/src/core/column/column_dictionary.h | 8 +-------
be/src/core/column/column_dummy.h | 2 --
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/be/src/core/column/column_dictionary.h
b/be/src/core/column/column_dictionary.h
index 7c60c7613e4..2fe0194db93 100644
--- a/be/src/core/column/column_dictionary.h
+++ b/be/src/core/column/column_dictionary.h
@@ -282,10 +282,7 @@ public:
void reserve(size_t n) { _dict_data->reserve(n); }
- void insert_value(const StringRef& value) {
- _dict_data->push_back_without_reserve(value);
- _total_str_len += value.size;
- }
+ void insert_value(const StringRef& value) {
_dict_data->push_back_without_reserve(value); }
Int32 find_code(const StringRef& value) const {
// _dict_data->size will not exceed the range of T.
@@ -410,8 +407,6 @@ public:
bool empty() const { return _dict_data->empty(); }
- size_t avg_str_len() { return empty() ? 0 : _total_str_len /
_dict_data->size(); }
-
size_t size() const {
if (!_dict_data) {
return 0;
@@ -446,7 +441,6 @@ public:
mutable HashValueContainer _hash_values;
mutable std::vector<uint8_t> _compute_hash_value_flags;
IColumn::Permutation _perm;
- size_t _total_str_len = 0;
};
size_t serialize_size_at(size_t row) const override { return
sizeof(value_type); }
diff --git a/be/src/core/column/column_dummy.h
b/be/src/core/column/column_dummy.h
index 30264f672cc..ce676ed888c 100644
--- a/be/src/core/column/column_dummy.h
+++ b/be/src/core/column/column_dummy.h
@@ -145,8 +145,6 @@ public:
for (size_t i = begin; i < end; ++i) res->insert_from(*this,
selector[i]);
}
- void addSize(size_t delta) { s += delta; }
-
void replace_column_data(const IColumn& rhs, size_t row, size_t self_row =
0) override {
throw doris::Exception(ErrorCode::INTERNAL_ERROR,
"should not call the method in column dummy");
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
