bobhan1 commented on PR #67292: URL: https://github.com/apache/doris/pull/67292#issuecomment-6497521657
/review Please re-evaluate the existing blocking P1 finding: https://github.com/apache/doris/pull/67292#discussion_r4344901080. This issue has been fixed in the current head, `b237ebcd675c0b8a6b9a22ab49253d272b318acd`: https://github.com/apache/doris/commit/b237ebcd675c0b8a6b9a22ab49253d272b318acd. `AsyncCacheWriteManager::should_skip_block_writeback()` no longer calls the grid-only `BlockFileCache::probe()`. It now calls `is_range_downloaded_or_downloading()`, which walks actual cached intervals, including historical non-aligned blocks restored after an upgrade. Complete contiguous DOWNLOADED/DOWNLOADING coverage skips writeback; incomplete coverage proceeds through the existing interval-aware `get_or_set()` persistence path. The fix includes `SkipsMixedIrregularCoverageWithoutAllocating` and `FillsRestoredIrregularCacheGap`. The latter persists an irregular block, reopens the cache, and fills the adjacent gap, covering the historical-cache restoration scenario. The latest review targeted this fixed head but still carried the original P1 in `existing_blocking_comment_ids`. Please trace the updated call chain and explicitly reassess its applicability. If the original P1 is fixed, mark it as fixed and omit it from the blocking findings. If it still applies, provide a concrete reachable call chain on this head that still reaches the grid-only probe. This focus is additional to the normal review and does not ask to ignore other findings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
