github-actions[bot] commented on code in PR #69830:
URL: https://github.com/apache/doris/pull/69830#discussion_r4422669944
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/properties/RequestPropertyDeriver.java:
##########
@@ -548,13 +547,9 @@ private boolean shouldUseParent(List<ExprId>
parentHashExprIds, PhysicalHashAggr
* naturally) or the FE local-shuffle planner (which plans the correct
bucket-hash
* local exchanges): with the BE-planned local shuffle the backend cannot
infer the
* correct local shuffle type for the set sink/probe and computes wrong
results.
- * It also requires the nereids distribute planner: the legacy coordinator
only
- * supports bucket-shuffle-partitioned sinks whose dest fragment contains
a bucket
- * shuffle join.
*/
private boolean setOperationBucketShuffleAllowed() {
return connectContext != null
Review Comment:
[P1] Keep set-operation bucket-shuffle properties aligned with the
translated receiver — when `enable_local_shuffle=false` and
`enable_local_shuffle_planner=false`, `setOperationBucketShuffleAllowed()` now
still lets the regulator choose a STORAGE_BUCKETED basic child, but
`PhysicalPlanTranslator.visitPhysicalSetOperation` does not set
`SetOperationNode.BUCKET_SHUFFLE` because it gates the marker on
`enable_local_shuffle_planner`. The resulting fragment still routes the other
UNION/EXCEPT branch by bucket, while `PlanFragment.hasBucketShuffleNode()` and
`UnassignedScanBucketOlapTableJob.shouldFillUpInstances()` miss the marker and
do not create receivers for pruned basic buckets, so rows routed to those
buckets can be dropped. Tighten the property gate to match translation or set
the marker for this allowed no-local-shuffle case, and add a pruned
UNION/EXCEPT regression with both local-shuffle settings disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
