924060929 commented on code in PR #69830:
URL: https://github.com/apache/doris/pull/69830#discussion_r4422889229
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/properties/RequestPropertyDeriver.java:
##########
@@ -548,13 +547,9 @@ private boolean shouldUseParent(List<ExprId>
parentHashExprIds, PhysicalHashAggr
* naturally) or the FE local-shuffle planner (which plans the correct
bucket-hash
* local exchanges): with the BE-planned local shuffle the backend cannot
infer the
* correct local shuffle type for the set sink/probe and computes wrong
results.
- * It also requires the nereids distribute planner: the legacy coordinator
only
- * supports bucket-shuffle-partitioned sinks whose dest fragment contains
a bucket
- * shuffle join.
*/
private boolean setOperationBucketShuffleAllowed() {
return connectContext != null
Review Comment:
Fixed in 18126a60b06. The translator now derives BUCKET_SHUFFLE from the
selected child distribution instead of rechecking enable_local_shuffle_planner;
legality and bucket alignment remain owned by property derivation/regulation.
This retains missing-bucket receiver allocation when both local-shuffle flags
are disabled without excluding valid bucket-shuffle plans. Added a
planner/scheduler regression for pruned UNION and EXCEPT across all four flag
combinations, including complete receiver bucket coverage. All 36 focused FE
cases, the FE build and Checkstyle passed. Full BE-backed query-result
execution was not run locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
