github-actions[bot] commented on code in PR #69806:
URL: https://github.com/apache/doris/pull/69806#discussion_r4426087583


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/scan/PluginDrivenScanNode.java:
##########
@@ -1799,8 +1815,8 @@ public List<Split> getSplits(int numBackends) throws 
UserException {
                 .explainOnly(isExplainOnly())
                 .build();

Review Comment:
   [P1] Route scan-node property loading through the retained source 
observation. `readMetadata` now protects `buildColumnHandles` and the later 
`planScan`, but `getOrLoadPropertiesResult` still invokes 
`scanProvider.getScanNodePropertiesResult` directly. For Iceberg, that call 
loads the table and the new `wrapTableLoadFailure` converts a concurrent drop 
into `ConnectorTableNotFoundException`; if the drop happens after node creation 
and before `getNodeExplainString`/`createScanRangeLocations`, the exception is 
raised before `planScan`, so the retained observation never retires the stale 
object, numeric ID route, or connector caches. Execute this provider read 
through the same observation (while keeping its TCCL boundary) and add a 
drop-before-properties regression.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to