924060929 commented on code in PR #69806:
URL: https://github.com/apache/doris/pull/69806#discussion_r4426395157
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/scan/PluginDrivenScanNode.java:
##########
@@ -1799,8 +1815,8 @@ public List<Split> getSplits(int numBackends) throws
UserException {
.explainOnly(isExplainOnly())
.build();
Review Comment:
Fixed in 3811ddca4396. getOrLoadPropertiesResult now invokes the existing
provider supplier through the scan node's retained pre-handle MetadataRead,
preserving the plugin TCCL boundary. The successful property result is still
memoized once; no additional name or existence load is introduced.
Four tests drive real getNodeExplainString calls: confirmed source absence
before planning retires the stale base identity; delayed absence cannot clear a
same-name replacement; successful properties are loaded once across repeated
explains without reloading table names; and an unrelated permission failure
propagates unchanged without retiring the source. The first regression fails on
the previous head, while the other controls pass there.
Validation: 504 focused unit cases passed across 44 classes; FE build and
Checkstyle passed. Controlled providers, not a live external-service
integration run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
