raghav-reglobe commented on PR #66804:
URL: https://github.com/apache/doris/pull/66804#issuecomment-6594691800
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#66804
commit: 15fefc9f965f5688801765fb0300be1aa7d8dc98
base: 31a036fbcda17fcbebd8d527393d3ced10e28702
reviewed_at: 2026-11-03T08:58+05:30
reviewer: raghav-reglobe
model: claude-fable-5-1
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 1}
rounds: 1
converged: true
```
**Notes for maintainers**
- `regression-test/suites/cloud_p0/cache/test_load_cache.groovy:363` — Nit
(process): scenario 3 pins the opt-in (Disposable +0 elements / +0 bytes,
Normal +91163 bytes inside the import band of scenario 2); its expectations
were derived from the BE's queue selection (`file_scanner_v2.cpp`,
`file_cache_common.h`, `block_file_cache.cpp`), not from a run.
- The head was reviewed as a rebased candidate on master 7cca01bc6cd6 before
the push (baseline "local ref", not the CI PR-base sha); the three-file diff is
the one the PR now carries.
- Not verified locally: no build and no regression run (no JDK on the review
machine); the `VarAttr` annotation's compile correctness was argued from
`VarAttrDef.java`'s source.
- PR body corrected with the push: regression test ticked (scenario 3),
template placeholders dropped, release note aligned with the variable's
description.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
