924060929 commented on code in PR #63612:
URL: https://github.com/apache/doris/pull/63612#discussion_r4482419271
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalMetaCacheMgr.java:
##########
@@ -246,8 +246,10 @@ public void invalidateCatalog(long catalogId) {
cache, catalogId, "invalidateCatalog",
() -> cache.invalidateCatalogEntries(catalogId)));
} finally {
- // This cache has no catalog-scoped key, so catalog
invalidation must clear it globally.
- invalidateSortedPartitionsCache();
+ CatalogIf<?> catalog = getCatalog(catalogId);
Review Comment:
Fixed in d7fba292abab3e260f90e2ca3e9c92af2de81446. Catalog entry refresh and
runtime retirement now share invalidateCatalogCaches(), which invokes
Env.onCatalogChanged() and retains the final row-count invalidation barrier.
ExternalCatalog passes its own catalog name into removeCatalog(id, name),
including after CatalogMgr has unpublished the object. The existing per-family
exception isolation remains in Env. Added controls cover direct removal, reset,
property changes, detached owners and connector failure, while checking that an
unrelated catalog remains current; all focused FE tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
