924060929 commented on PR #63612:
URL: https://github.com/apache/doris/pull/63612#issuecomment-6664276111
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#63612
commit: d8e8ae1ba63fc0ece31e659de8c6bc603eec95cf
base: b6c67510385391d0dd913589f1b323ec86ba7bd6
reviewed_at: 2026-11-06T01:10+08:00
reviewer: 924060929
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 2
converged: true
```
**Notes for maintainers**
- Solo incremental review of all 42 changed files: 41 patch bodies retain
the completed d7fba29 review evidence, the new test-file patch and its full
context were read; two clean rounds, no remaining findings.
-
`fe/fe-core/src/test/java/org/apache/doris/datasource/plugin/PluginDrivenExternalCatalogConcurrencyTest.java:267`
— fixed six old-overload verifications and one doAnswer target to require
removeCatalog(id, name). Catalog-monitor ownership, old-budget close, zero used
weight and single-retirement assertions are preserved; production source is
unchanged.
- The local baseline reproduces the exact seven non-muted CI failures (18
cases: six failures, one error). Expanded preset validation passes 33 classes /
618 tests, zero failures/errors/skips, including the entire plugin package plus
catalog/replay/row-count/sorted/MV controls; Checkstyle and diff checks pass.
- Preset validation recompiles FE and test sources. Production-package and
two-FE replay evidence are explicitly inherited from d7fba29, whose production
source is byte-identical; no new cluster, full FE or full P0 run is claimed
this cycle. Remote CI/review status remains a separate gate.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
