924060929 commented on PR #63612:
URL: https://github.com/apache/doris/pull/63612#issuecomment-6662203496
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#63612
commit: d7fba292abab3e260f90e2ca3e9c92af2de81446
base: b6c67510385391d0dd913589f1b323ec86ba7bd6
reviewed_at: 2026-11-05T23:39+08:00
reviewer: 924060929
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 2
converged: true
```
**Notes for maintainers**
- Solo review of all 41 changed files with gpt-6.1-sol/xhigh: 33 unchanged
patch bodies retain prior complete-review evidence, eight new/changed bodies
re-read; two clean rounds, no remaining findings. Prior catalog-retirement
dismissal was withdrawn and repaired.
-
`fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalMetaCacheMgr.java:248`
— catalog refresh and runtime retirement now share scoped SQL/sorted/MV
invalidation, retain detached-owner names and preserve per-family failure
isolation plus the final row-count barrier.
Direct/reset/property/detached/failure controls pass.
- Fix-phase validation: 11 FE test classes / 182 distinct cases, zero final
failures/errors/skips; Checkstyle and build.sh --fe pass. These are focused
tests, not the full FE or P0 gates.
-
`regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/Suite.groovy:483`
— bounded shared warmup establishes positive cache-admission preconditions;
immediate post-write miss assertions and golden results remain unchanged. A
controlled event with the failing CI BE binary reproduces original failure and
repaired success; historical scheduling is not claimed.
- Three related preset suites pass with two native FEs and the exact CI BE
revision 8361b8b4879238591010c724aee1d9d58b0f0623 (execution version 19). The
replay body actually runs; same-host port discovery required a temporary
follower JDBC-port routing override only, restored afterward. Initial single-FE
early-return success is not counted as replay proof.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
