github-actions[bot] commented on code in PR #69032:
URL: https://github.com/apache/doris/pull/69032#discussion_r4551380707
##########
be/src/format_v2/table/iceberg_reader.cpp:
##########
@@ -2246,7 +2300,7 @@ Status
IcebergTableReader::_create_delete_file_reader(const TIcebergDeleteFileDe
*reader = std::make_unique<format::parquet::ParquetReader>(
system_properties, file_description, io_ctx, _scanner_profile,
std::nullopt,
enable_mapping_timestamp_tz, enable_mapping_varbinary, "",
preserve_binary_uuid(),
- _parquet_profile_cache);
+ _parquet_profile_cache, std::nullopt,
parquet_spatial_annotations_as_bytes());
Review Comment:
[P2] Preserve opaque BINARY keys in equality-delete readers
For a table `id INT, k BINARY`, an ordinary BINARY data file plus a
spatially annotated equality-delete file whose `k` contains the opaque TRIANGLE
WKB used by the new binary-read fixture still fails a scan. This constructor
enables typed decoding, while `_load_equality_delete_file()` applies only
timestamp overrides and opens the tombstone with its physical spatial type.
`SpatialParquetSerDe` rejects the bytes before the BINARY comparison cast. The
new `annotate_file_schema()` override runs only on the data reader, so it
cannot repair this separate consumer. Resolve BINARY leaves using the complete
table schema before opening equality-delete inputs, and cover annotated
tombstones/hidden keys with opaque bytes and NULLs. Source tracing only; no
Doris test ran.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
