jacktengg commented on PR #70485:
URL: https://github.com/apache/doris/pull/70485#issuecomment-6919264428

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#70485
   commit: 96a2c6a86ae03750a5de3b972f867e713b4af850
   base: 9e598d38789571a7fc30652aa054f035bd4f1184
   reviewed_at: 2026-11-16T22:29+08:00
   reviewer: jacktengg
   model: gpt-6-astra
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 1, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - `be/src/exprs/function/function_date_or_datetime_computation.h:795` — 
Nonblocking Minor: the newly used preferred-offset output helper performs the 
target civil lookup twice (see 
`be/src/core/value/timestamptz_value.cpp:172-173`). Reuse the existing lookup's 
`trans` for SKIPPED and `pre` otherwise, retaining repeated-offset selection. 
This is distinct from the fixed input absolute lookup; results remain correct 
and no speedup was measured.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to