jacktengg commented on PR #70485:
URL: https://github.com/apache/doris/pull/70485#issuecomment-6945422315
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70485
commit: 8609fb6ca24da25d67d14932dd64ff3c880b4ac4
base: e04a785e20a87ef910ec756ff6b4d269298addb6
reviewed_at: 2026-11-17T18:28+08:00
reviewer: jacktengg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 1, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- No new findings after the rebase.
`be/src/exprs/function/function_date_or_datetime_computation.h:775-812` keeps
one execute definition, the year specialization, upstream timezone-aware
DAY/add-sub dispatch, and the two-argument diff/extract fallback.
- Known Minor F-02 is inherited unchanged at
`fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/PartitionPrunerTest.java:156-160`:
the old gap fixture has an unreachable target under shifted-gap semantics. Its
existing recommendation remains to mirror the corrected SQL fixture (source
upper `2023-03-10 08:10:00.900000 +00:00`, target `2024-03-10 07:30:00.100000
+00:00`). This is nonblocking and is not a newly reported defect.
- Old F-01 remains fixed at
`be/src/core/value/timestamptz_value.cpp:202-204`; all 13 latest prior
dismissal dispositions were retained after premise checks.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]